added type declarations #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ha-limLee
commented
Sep 17, 2023
Comment on lines
+1
to
+3
| { | ||
| "typescript.tsdk": "node_modules/typescript/lib" | ||
| } |
There was a problem hiding this comment.
This is vscode ts version setting.
It fixes ts version to workspace's.
Since vscode comes with internal ts, different version of vscode can cause syntactic error.
This reverts commit 93e5114.
Ha-limLee
commented
Sep 17, 2023
|
|
||
| declare class npyjs { | ||
|
|
||
| constructor(opts?: never); |
There was a problem hiding this comment.
Made constructor receive nothing.
If user give any argument, It will throw type error.
Ha-limLee
commented
Sep 17, 2023
| }; | ||
| }; | ||
|
|
||
| export type Parsed = ValueOf<{ |
There was a problem hiding this comment.
This is return type of parse method.
It is tagged union type. So you can narrow the type using if or switch statements.
|
This is AWESOME, thank you @Ha-limLee for this high-impact contribution — I know a lot of users will be very grateful to have these types! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @j6k4m8. Appreciate your great works.
I added some type improvements here.
Thanks.
close #32