Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: collect the log of the backup failed #8205

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from ldming, zjx20 and a team as code owners September 25, 2024 07:14
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.38%. Comparing base (e0bd32a) to head (aa420b4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ollers/dataprotection/log_collection_controller.go 26.31% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
+ Coverage   60.88%   61.38%   +0.50%     
==========================================
  Files         354      354              
  Lines       40874    41183     +309     
==========================================
+ Hits        24885    25282     +397     
+ Misses      13722    13657      -65     
+ Partials     2267     2244      -23     
Flag Coverage Δ
unittests 61.38% <26.31%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Sep 25, 2024
@wangyelei wangyelei merged commit 78fb0b1 into main Sep 26, 2024
38 checks passed
@wangyelei wangyelei deleted the bugfix/collect_backup_log_failed branch September 26, 2024 01:15
@github-actions github-actions bot added this to the Release 0.9.2 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants