Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create job failed with no this sa for custom ops #6415

Merged
merged 2 commits into from
Jan 10, 2024
Merged

fix: create job failed with no this sa for custom ops #6415

merged 2 commits into from
Jan 10, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (636c798) 66.54% compared to head (1f307d5) 66.54%.

❗ Current head 1f307d5 differs from pull request most recent head ac2b3fa. Consider uploading reports for the commit ac2b3fa to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6415   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files         298      298           
  Lines       35697    35692    -5     
=======================================
- Hits        23753    23752    -1     
- Misses       9907     9917   +10     
+ Partials     2037     2023   -14
Flag Coverage Δ
unittests 66.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 10, 2024
@wangyelei wangyelei mentioned this pull request Jan 10, 2024
Closed
@wangyelei
Copy link
Contributor Author

/approved

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jan 10, 2024
@wangyelei wangyelei merged commit 4e671c8 into main Jan 10, 2024
75 checks passed
@wangyelei wangyelei deleted the bugfix/custom_ops_no_sa branch January 10, 2024 14:22
@wangyelei
Copy link
Contributor Author

/cherry-pick release-0.8

@github-actions github-actions bot added this to the Release 0.8.0 milestone Jan 10, 2024
@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/7476289806

github-actions bot pushed a commit that referenced this pull request Jan 10, 2024
@wangyelei
fix: create job failed with no this sa for custom ops (#6415)
8504bc4 
(cherry picked from commit 4e671c8)
@JashBook JashBook linked an issue Jan 11, 2024 that may be closed by this pull request
[BUG] kafka cluster custom-ops serviceaccount not found apecloud/kbcli#224
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@leon-inf leon-inf Awaiting requested review from leon-inf

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie

Assignees
No one assigned
Labels
approved PR Approved Test enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

[BUG] kafka cluster custom-ops serviceaccount not found
3 participants
@wangyelei @ldming @apecloud-bot