chore: udpate Makefile on buiding embeding charts #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshanying
requested review from
nayutah,
ldming,
heng4fun,
free6om,
wangyelei,
leon-inf and
1aal
as code owners
wangyelei
approved these changes
Sep 27, 2024
ldming
approved these changes
Sep 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 43.50% 43.50%
=======================================
Files 175 175
Lines 24885 24885
=======================================
Hits 10825 10825
Misses 12798 12798
Partials 1262 1262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
(cherry picked from commit e984a02)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare charts, not only rendered cluster.yaml.