Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prefer using StorageProvider from the dataprotection API group #324

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

zjx20
Copy link
Contributor

@zjx20 zjx20 commented Apr 29, 2024

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Apr 29, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 35.18519% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 42.84%. Comparing base (7f7a69e) to head (1cb1c1a).

❗ Current head 1cb1c1a differs from pull request most recent head c349da1. Consider uploading reports for the commit c349da1 to get more accurate results

Files Patch % Lines
pkg/cmd/backuprepo/common.go 37.50% 25 Missing ⚠️
pkg/cmd/backuprepo/create.go 16.66% 5 Missing ⚠️
pkg/testing/fake.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   42.85%   42.84%   -0.02%     
==========================================
  Files         213      213              
  Lines       28993    29031      +38     
==========================================
+ Hits        12426    12438      +12     
- Misses      15033    15059      +26     
  Partials     1534     1534              
Flag Coverage Δ
unittests 42.84% <35.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjx20 zjx20 merged commit c23d0ef into main Apr 29, 2024
5 checks passed
@zjx20 zjx20 deleted the support/dp-storageprovider branch April 29, 2024 02:59
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 29, 2024
@zjx20
Copy link
Contributor Author

zjx20 commented Apr 29, 2024

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8872673800

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants