Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get image registry by k8s provider and region #307

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Apr 8, 2024

Get the default image registry by k8s provider and region info and use it when install KubeBlocks.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 54.02299% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 42.89%. Comparing base (f2e2e7c) to head (8dbff3c).

Files Patch % Lines
pkg/util/provider.go 63.93% 18 Missing and 4 partials ⚠️
pkg/cmd/kubeblocks/install.go 28.00% 14 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   42.86%   42.89%   +0.02%     
==========================================
  Files         213      213              
  Lines       28863    28946      +83     
==========================================
+ Hits        12372    12415      +43     
- Misses      14972    15003      +31     
- Partials     1519     1528       +9     
Flag Coverage Δ
unittests 42.89% <54.02%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 9, 2024
@ldming ldming marked this pull request as ready for review April 9, 2024 01:50
@ldming ldming merged commit 7dc2556 into main Apr 9, 2024
18 checks passed
@ldming ldming deleted the support/set-image-registry-by-k8s-region branch April 9, 2024 15:11
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 9, 2024
@ldming
Copy link
Collaborator Author

ldming commented Apr 10, 2024

/cherry-pick release-0.9

Copy link

🤖 says: Error cherry-picking.

Failed to merge submodule addons (not checked out)
CONFLICT (submodule): Merge conflict in addons
warning: Cannot merge binary files: pkg/cluster/charts/llm-cluster.tgz (HEAD vs. 7dc2556 (chore: get image registry by k8s provider and region (#307)))
Auto-merging pkg/cluster/charts/llm-cluster.tgz
CONFLICT (content): Merge conflict in pkg/cluster/charts/llm-cluster.tgz
Recursive merging with submodules currently only supports trivial cases.
Please manually handle the merging of each conflicted submodule.
This can be accomplished with the following steps:

  • come back to superproject and run:

    git add addons

    to record the above merge or update

  • resolve any other conflicts in the superproject

  • commit the resulting index in the superproject
    error: could not apply 7dc2556... chore: get image registry by k8s provider and region (chore: get image registry by k8s provider and region #307)
    hint: After resolving the conflicts, mark them with
    hint: "git add/rm ", then run
    hint: "git cherry-pick --continue".
    hint: You can instead skip this commit with "git cherry-pick --skip".
    hint: To abort and get back to the state before "git cherry-pick",
    hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/8625321209

ldming added a commit that referenced this pull request Apr 10, 2024
@ldming
Copy link
Collaborator Author

ldming commented Apr 10, 2024

Manually picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Auto set the image repo for k8s env
3 participants