Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust configconstraint api (#297) #298

Merged

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt linked an issue Apr 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Apr 2, 2024
@sophon-zt sophon-zt linked an issue Apr 2, 2024 that may be closed by this pull request
@sophon-zt sophon-zt marked this pull request as ready for review April 2, 2024 14:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 43.30%. Comparing base (32b2fd2) to head (210e821).

Files Patch % Lines
pkg/cmd/cluster/config_observer.go 0.00% 6 Missing ⚠️
pkg/testing/fake.go 0.00% 4 Missing ⚠️
pkg/util/util.go 55.55% 2 Missing and 2 partials ⚠️
pkg/cmd/cluster/config_edit.go 0.00% 3 Missing ⚠️
pkg/cmd/cluster/update.go 33.33% 2 Missing ⚠️
pkg/cmd/builder/template/helm_helper.go 0.00% 1 Missing ⚠️
pkg/cmd/cluster/config_diff.go 0.00% 1 Missing ⚠️
pkg/cmd/cluster/config_ops.go 66.66% 0 Missing and 1 partial ⚠️
pkg/cmd/cluster/config_resource.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   43.30%   43.30%           
=======================================
  Files         217      217           
  Lines       29146    29147    +1     
=======================================
+ Hits        12622    12623    +1     
  Misses      14974    14974           
  Partials     1550     1550           
Flag Coverage Δ
unittests 43.30% <34.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt merged commit bb8ff77 into main Apr 3, 2024
12 checks passed
@sophon-zt sophon-zt deleted the support/improvement-update-configconstraint-api-issue297 branch April 3, 2024 02:43
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 3, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

github-actions bot commented Apr 3, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8532481300

github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] update configconstraint api [BUG]PG configure not work
3 participants