Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support convert configconstraint from v1alpha1 to v1beta1 (#357) #358

Conversation

sophon-zt
Copy link
Contributor

No description provided.

@sophon-zt sophon-zt requested a review from nayutah as a code owner May 16, 2024 10:13
@sophon-zt sophon-zt linked an issue May 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label May 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 45.06%. Comparing base (428f968) to head (69f8246).

Files Patch % Lines
pkg/cmd/kubeblocks/upgrade.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   45.04%   45.06%   +0.01%     
==========================================
  Files         157      157              
  Lines       22846    22864      +18     
==========================================
+ Hits        10292    10304      +12     
- Misses      11323    11327       +4     
- Partials     1231     1233       +2     
Flag Coverage Δ
unittests 45.06% <64.70%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt merged commit 1b5e79a into main May 20, 2024
14 checks passed
@sophon-zt sophon-zt deleted the feature/support-convert-configconstraint-from-v1alpha1-to-v1beta1-issue357 branch May 20, 2024 12:15
@github-actions github-actions bot added this to the Release 0.9.0 milestone May 20, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/9158517111

github-actions bot pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] support convert configconstraint from v1alpha1 to v1beta1
3 participants