-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: support convert configconstraint from v1alpha1 to v1beta1 (#358)
(cherry picked from commit 1b5e79a)
- Loading branch information
Showing
6 changed files
with
245 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| Copyright (C) 2022-2024 ApeCloud Co., Ltd | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package conversion | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | ||
| appsv1beta1 "github.com/apecloud/kubeblocks/apis/apps/v1beta1" | ||
| "github.com/apecloud/kubeblocks/pkg/constant" | ||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| apiruntime "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/client-go/dynamic" | ||
| "k8s.io/klog/v2" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "github.com/apecloud/kbcli/pkg/types" | ||
| "github.com/apecloud/kbcli/pkg/util" | ||
| ) | ||
|
|
||
| const ( | ||
| OldVersion = "08" | ||
| NewVersion = "09" | ||
| ) | ||
|
|
||
| func FetchAndConversionResources(versionMeta *VersionConversionMeta) ([]unstructured.Unstructured, error) { | ||
| var resources []unstructured.Unstructured | ||
|
|
||
| if versionMeta.FromVersion == versionMeta.ToVersion { | ||
| return nil, nil | ||
| } | ||
|
|
||
| if versionMeta.FromVersion != OldVersion || versionMeta.ToVersion != NewVersion { | ||
| klog.V(1).Infof("not to convert configconstraint multiversion") | ||
| return nil, nil | ||
| } | ||
|
|
||
| oldResources, err := ResourcesWithGVR(versionMeta, types.ConfigConstraintOldGVR(), metav1.ListOptions{}) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| for _, oldObj := range oldResources { | ||
| newObj := appsv1beta1.ConfigConstraint{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: types.KindConfigConstraint, | ||
| APIVersion: types.ConfigConstraintGVR().GroupVersion().String(), | ||
| }, | ||
| } | ||
| klog.V(1).Infof("convert configconstraint[%s] cr from v1alpha1 to v1beta1", oldObj.GetName()) | ||
| // If v1alpha1 is converted from v1beta1 version | ||
| if hasConversionVersion(&oldObj) { | ||
| klog.V(1).Infof("configconstraint[%s] v1alpha1 is converted from v1beta1 version and ignore.", | ||
| client.ObjectKeyFromObject(&oldObj).String()) | ||
| continue | ||
| } | ||
| // If the converted version v1beta1 already exists | ||
| if hasValidBetaVersion(&oldObj, versionMeta) { | ||
| klog.V(1).Infof("configconstraint[%s] v1beta1 already exist and ignore.", | ||
| client.ObjectKeyFromObject(&oldObj).String()) | ||
| continue | ||
| } | ||
| if err := oldObj.ConvertTo(&newObj); err != nil { | ||
| return nil, err | ||
| } | ||
| item, err := apiruntime.DefaultUnstructuredConverter.ToUnstructured(&newObj) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| resources = append(resources, unstructured.Unstructured{Object: item}) | ||
| } | ||
| return resources, nil | ||
| } | ||
|
|
||
| func hasValidBetaVersion(obj *appsv1alpha1.ConfigConstraint, dynamic dynamic.Interface) bool { | ||
| newObj := appsv1beta1.ConfigConstraint{} | ||
| if err := util.GetResourceObjectFromGVR(types.ConfigConstraintGVR(), client.ObjectKeyFromObject(obj), dynamic, &newObj); err != nil { | ||
| return false | ||
| } | ||
|
|
||
| return hasConversionVersion(&newObj) | ||
| } | ||
|
|
||
| func hasConversionVersion(obj client.Object) bool { | ||
| annotations := obj.GetAnnotations() | ||
| if len(annotations) == 0 { | ||
| return false | ||
| } | ||
| return annotations[constant.KubeblocksAPIConversionTypeAnnotationName] == constant.MigratedAPIVersion | ||
| } | ||
|
|
||
| func UpdateNewVersionResources(versionMeta *VersionConversionMeta, targetObjects []unstructured.Unstructured) error { | ||
| if len(targetObjects) == 0 { | ||
| return nil | ||
| } | ||
| if versionMeta.FromVersion == versionMeta.ToVersion { | ||
| return nil | ||
| } | ||
|
|
||
| for _, unstructuredObj := range targetObjects { | ||
| klog.V(1).Infof("update CR %s", unstructuredObj.GetName()) | ||
| _, err := versionMeta.Resource(types.ConfigConstraintGVR()). | ||
| Update(versionMeta.Ctx, &unstructuredObj, metav1.UpdateOptions{}) | ||
| if err != nil { | ||
| if apierrors.IsNotFound(err) { | ||
| if _, err := versionMeta.Resource(types.ConfigConstraintGVR()). | ||
| Create(versionMeta.Ctx, &unstructuredObj, metav1.CreateOptions{}); err != nil { | ||
| klog.V(1).ErrorS(err, "failed to create configConstraint") | ||
| return err | ||
| } | ||
| continue | ||
| } | ||
| klog.V(1).ErrorS(err, fmt.Sprintf("failed to update configconstraint cr[%v]", unstructuredObj.GetName())) | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /* | ||
| Copyright (C) 2022-2024 ApeCloud Co., Ltd | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package conversion | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "k8s.io/client-go/dynamic" | ||
|
|
||
| "github.com/apecloud/kbcli/pkg/util/breakingchange" | ||
| ) | ||
|
|
||
| type VersionConversionMeta struct { | ||
| dynamic.Interface | ||
| Ctx context.Context | ||
|
|
||
| FromVersion string | ||
| ToVersion string | ||
| } | ||
|
|
||
| func NewVersionConversion(dynamic dynamic.Interface, fromVersion, toVersion string) *VersionConversionMeta { | ||
| return &VersionConversionMeta{ | ||
| Ctx: context.Background(), | ||
| Interface: dynamic, | ||
| FromVersion: breakingchange.GetMajorMinorVersion(fromVersion), | ||
| ToVersion: breakingchange.GetMajorMinorVersion(toVersion), | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* | ||
| Copyright (C) 2022-2024 ApeCloud Co., Ltd | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package conversion | ||
|
|
||
| import ( | ||
| appsv1alpha1 "github.com/apecloud/kubeblocks/apis/apps/v1alpha1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| apiruntime "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| ) | ||
|
|
||
| func ResourcesWithGVR(versionMeta *VersionConversionMeta, gvr schema.GroupVersionResource, listOptions metav1.ListOptions) ([]appsv1alpha1.ConfigConstraint, error) { | ||
| var resourcesList []appsv1alpha1.ConfigConstraint | ||
|
|
||
| objList, err := versionMeta.Resource(gvr).List(versionMeta.Ctx, listOptions) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| for _, v := range objList.Items { | ||
| obj := appsv1alpha1.ConfigConstraint{} | ||
| if err := apiruntime.DefaultUnstructuredConverter.FromUnstructured(v.Object, &obj); err != nil { | ||
| return nil, err | ||
| } | ||
| resourcesList = append(resourcesList, obj) | ||
| } | ||
| return resourcesList, nil | ||
| } |