-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-285] Added docker images for spark-sedona-zeppelin and spark-sedona-jupyterlab #843
Conversation
@kartikeyhadiya Thanks for your contribution. A few comments:
|
Thanks for your input. |
I have created jira ticket and included it in main comment |
@kartikeyhadiya Yes, for No.5, we will need docs.github.com/en/actions/creating-actions/creating-a-docker-container-action |
…ooks, instead added binder folder as volume in docker-compose file.
… License as file header to .dockerfiles and .sh script
…pelin and jupyterlab. By default spark 3.3.2 version used but can be changed with --build-args. Added workflow for pushing image to dockerhub
Updated dokcerhub-deploy.yml workflow
Hey, @jiayuasu sorry for so much delay had a busy month at work.
Please verify and let me know if any other suggestions/changes required. |
Hey, @jiayuasu just following up on this. |
@kartikeyhadiya Thanks for the great work here. I will take a look your fork and try to run it myself. |
Thank you, please let me know if anything else is required. |
@kartikeyhadiya Due to the complexity of this task, I have taken over this and created another PR based on this PR: #939 Thanks for your help! |
Added docker images for spark-sedona:1.3.1-zeppelin and spark-sedona1.4.0-jupyterlab
Issue: #842
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
What changes were proposed in this PR?
Added docker images for spark-sedona:1.3.1-zeppelin and spark-sedona1.4.0-jupyterlab
How was this patch tested?
Local environment with docker.
Did this PR include necessary documentation updates?