[SEDONA-607] Fix error message enhancements for geometry functions #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Aug 21, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Aug 21, 2024
…1555) * Fix error message enhancements for geometry functions * Fix compilation for scala 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
This patch is based on #1525, it generates enhanced error messages when the input arguments of geometry functions are not literal. The input arguments may help troubleshoot the cause of the errors.
Note: we originally planned to extract auxiliary fields from input rows and attach them to the error messages, but actually this is hard to implement since we don't know the types of columns that are not part of the function arguments. The error messages will only include arguments passed to the errored functions, including the input geometries. Hopefully this will be good enough for troubleshooting.
How was this patch tested?
Passing newly added tests.
Did this PR include necessary documentation updates?