Improve dimension table handing #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jackie-Jiang
commented
Sep 9, 2024
Jackie-Jiang
commented
- Introduce finer control and access on dimension table
- Do not always read the whole row for each lookup. In most cases we only need to access one single value
klsince
reviewed
Sep 9, 2024
| @@ -219,8 +218,7 @@ private void lookup(ValueBlock valueBlock, ValueAcceptor valueAcceptor) { | |||
| } | |||
| } | |||
| // lookup | |||
| GenericRow row = _dataManager.lookupRowByPrimaryKey(primaryKey); | |||
| Object value = row == null ? null : row.getValue(_dimColumnName); | |||
| Object value = _dataManager.lookupValue(primaryKey, _dimColumnName); | |||
There was a problem hiding this comment.
nice
but where lookupValues() method is used? or added for future use
There was a problem hiding this comment.
Sharp eyes! Yes it is a preparation for #13966
klsince
approved these changes
Sep 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13967 +/- ##
============================================
- Coverage 61.75% 57.88% -3.87%
- Complexity 207 219 +12
============================================
Files 2436 2612 +176
Lines 133233 143197 +9964
Branches 20636 21986 +1350
============================================
+ Hits 82274 82887 +613
- Misses 44911 53832 +8921
- Partials 6048 6478 +430
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.