ORC-1264: [C++] Add a writer option to align compression block with row group #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow group boundary
wgtmac
requested changes
Aug 21, 2024
wgtmac
reviewed
Aug 26, 2024
wgtmac
changed the title
wgtmac
reviewed
Sep 4, 2024
| * Get the current stripe position entries for the specified column. | ||
| * @return the position entries for the specified column. | ||
| */ | ||
| virtual std::vector<std::vector<int>> getCurrentStripePositionEntries(uint64_t columnId) = 0; |
There was a problem hiding this comment.
nit: I was thinking if we should design a better data structure, something like:
struct RowGroupPositions {
uint64_t columnId;
std::vector<int32_t> positions;
}
Then it can be reused if we want to add std::vector<RowGroupPositions> getPositionEntries(int stripe, std::vector<int> columnIds) in the future.
There was a problem hiding this comment.
I'll mark it in the next work.
There was a problem hiding this comment.
I'd suggest to do this all at once. If we don't change it in time, the public API will get released and we cannot change it any more.
Co-authored-by: Gang Wu <[email protected]>
Co-authored-by: Gang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for the ORC writer to ensure that the compression block is aligned with the row group boundary。
Why are the changes needed?
To reduce unnecessary I/O and decompression when PPD is in effect, we can enforce the compression block to be aligned with the row group boundary. For more detail, see link
How was this patch tested?
Uts in TestWriter.cc can convert this patch.
Was this patch authored or co-authored using generative AI tooling?
NO