Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1669: [C++] Upgrade libhdfs #1864

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ORC-1669: [C++] Upgrade libhdfs #1864

wants to merge 1 commit into from

Conversation

ffacs
Copy link
Contributor

@ffacs ffacs commented Mar 27, 2024

What changes were proposed in this pull request?

Upgrade libhdfs.

Why are the changes needed?

To #1857

How was this patch tested?

UT passed

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the CPP label Mar 27, 2024
@wgtmac
Copy link
Member

wgtmac commented Mar 28, 2024

CMake Error at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find Boost (missing: Boost_INCLUDE_DIR date_time) (Required is at
  least version "1.72.0")

It seems that the latest version of libhdfspp has a dependency on boost, which we don't want to add to our dependencies.

The ORC C++ library usually is integrated into larger systems which have built-in filesystem implementation and simply adapt orc::InputStream to their parities. As libhdfspp has been introduced 7 years ago and has not been actively maintained, I'd propose to remove its support. @dongjoon-hyun @stiga-huang WDYT?

@dongjoon-hyun
Copy link
Member

It's too bad. Apache ORC community cannot remove it at ORC 2.x because ORC 2.0.0 is released already and we follow Semantic Versioning policy. The best thing we can do is to deprecate it at Apache ORC 2.0.1.

@wgtmac
Copy link
Member

wgtmac commented Mar 29, 2024

That sounds good. Let me mark relevant code as deprecated first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants