Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15104: add timestamp in default gc_log name #2289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

interma
Copy link
Member

@interma interma commented Feb 2, 2021

Description

https://issues.apache.org/jira/browse/SOLR-15104

When restarting Solr, it will overwrite the gc log, this behavior is not friendly for debugging OOM issues.

Solution

Add timestamp in default gc_log name, so it doesn't overwrite the previous one.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

@interma interma changed the title Title: add timestamp in default gc_log name SOLR-15104: add timestamp in default gc_log name Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant