feat: support cuckoo filter and most commands #2545
+2,120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into cuckoo-filter
|
Running |
torwig
reviewed
Sep 19, 2024
|
@jonathanc-n Thank you for this contribution. Great job! |
|
Thanks for your contribution! However, I cannot find a proposal to state the design details and storage format of the new data structure. May I ask you provide such a proposal before we continue to review this patch? |
|
@PragmaTwice it is mentioned in #2539, I added some extra information to clarify some things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references issue: #2534
Added support for all commands except for SCANDUMP and LOADCHUNK.
The go cases are currently being worked on.