Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HUDI-5240] Reset the content during error handling in the log block reading #7434

Merged
merged 2 commits into from
Sep 22, 2024
Merged

[HUDI-5240] Reset the content during error handling in the log block reading #7434

merged 2 commits into from
Sep 22, 2024
+137 −0

Conversation

loukey-lj
Copy link
Contributor

@loukey-lj loukey-lj commented Dec 12, 2022 •
edited by yihua
Loading

Change Logs

If an exception occurs in the line 272~274, an error will be reported in the screenshot

image

Error stacktrace:

java.lang.IllegalStateException: Block has already been inflated
	at org.apache.hudi.common.util.ValidationUtils.checkState(ValidationUtils.java:76)
	at org.apache.hudi.common.table.log.block.HoodieLogBlock.inflate(HoodieLogBlock.java:308)
	at org.apache.hudi.common.table.log.block.HoodieLogBlock.inflate(HoodieLogBlock.java:324)

Impact

Fix bug in error handling of log reading.

Risk level (write none, low medium or high below)

low

Documentation Update

NA

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@XuQianJin-Stars
Copy link
Contributor

@hudi-bot run azure

@XuQianJin-Stars XuQianJin-Stars self-assigned this Jan 31, 2023
@bvaradar bvaradar self-assigned this Feb 18, 2023
@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Feb 26, 2024
yihua
yihua approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@yihua yihua left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added new tests to cover the case. Without the fix, some tests fail. After the fix, all new tests pass.

@yihua yihua changed the title [HUDI-5240] Clean content when recursive Invocation inflate [HUDI-5240] Reset content when recursively calling inflate in the log block reading Sep 22, 2024
@yihua yihua changed the title [HUDI-5240] Reset content when recursively calling inflate in the log block reading [HUDI-5240] Reset content when recursively calling inflate() in the log block reading Sep 22, 2024
@yihua yihua mentioned this pull request Sep 22, 2024
Open
@yihua yihua changed the title [HUDI-5240] Reset content when recursively calling inflate() in the log block reading [HUDI-5240] Reset the content during error handling in the log block reading Sep 22, 2024
This was referenced Sep 22, 2024
Open
Open
Open
@github-actions github-actions bot added size:M PR with lines of changes in (100, 300] and removed size:XS PR with lines of changes in <= 10 labels Sep 22, 2024
@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit 9c54838 into apache:master Sep 22, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihua yihua yihua approved these changes

@XuQianJin-Stars XuQianJin-Stars XuQianJin-Stars approved these changes

Assignees

@bvaradar bvaradar

@XuQianJin-Stars XuQianJin-Stars

Labels
size:M PR with lines of changes in (100, 300]
Projects
Hudi PR Support
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loukey-lj @XuQianJin-Stars @hudi-bot @yihua @bvaradar