[HUDI-8215] Support composite compaction strategy #11963
+144
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danny0405 Hi, I implemented the composite compaction strategy via chain calls. Looking forward to your review~ |
1. support composite compaction strategy Signed-off-by: TheR1sing3un <[email protected]>
TheR1sing3un
force-pushed
the
feat_compaction_strategy_chain
branch
from
126f5f6
to
75cffde
Compare
1. fix wrong class cast Signed-off-by: TheR1sing3un <[email protected]>
|
@hudi-bot run azure |
danny0405
reviewed
Sep 21, 2024
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
Outdated
Show resolved
Hide resolved
1. polish code Signed-off-by: TheR1sing3un <[email protected]>
danny0405
reviewed
Sep 21, 2024
| @@ -146,7 +146,7 @@ public class HoodieCompactionConfig extends HoodieConfig { | |||
| .markAdvanced() | |||
| .withDocumentation("Compaction strategy decides which file groups are picked up for " | |||
| + "compaction during each compaction run. By default. Hudi picks the log file " | |||
| + "with most accumulated unmerged data"); | |||
| + "with most accumulated unmerged data. Support composite strategy by providing, format: strategy_class_name1,strategy_class_name2,..."); | |||
There was a problem hiding this comment.
The strategy can be composed with multiple strategies by concatenating the class names with ','.
danny0405
reviewed
Sep 21, 2024
| public Builder withCompactionStrategy(CompactionStrategy... compactionStrategies) { | ||
| StringBuilder compactionStrategyBuilder = new StringBuilder(); | ||
| for (CompactionStrategy compactionStrategy : compactionStrategies) { | ||
| compactionStrategyBuilder.append(compactionStrategy.getClass().getName()).append(","); |
There was a problem hiding this comment.
Can we trim out the tailing ,?
danny0405
reviewed
Sep 21, 2024
|
|
||
| /** | ||
| * CompositeCompactionStrategy chains multiple compaction strategies together. | ||
| * The order of the strategies in the chain is important as the output of one strategy is passed as input to the next. |
There was a problem hiding this comment.
Can we address that the compisition predicate is and instead of or?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
low
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist