-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-8215] Support composite compaction strategy #11963
base: master
Are you sure you want to change the base?
[HUDI-8215] Support composite compaction strategy #11963
Conversation
@danny0405 Hi, I implemented the composite compaction strategy via chain calls. Looking forward to your review~ |
1. support composite compaction strategy Signed-off-by: TheR1sing3un <[email protected]>
126f5f6
to
75cffde
Compare
1. fix wrong class cast Signed-off-by: TheR1sing3un <[email protected]>
@hudi-bot run azure |
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
Outdated
Show resolved
Hide resolved
1. polish code Signed-off-by: TheR1sing3un <[email protected]>
@@ -146,7 +146,7 @@ public class HoodieCompactionConfig extends HoodieConfig { | |||
.markAdvanced() | |||
.withDocumentation("Compaction strategy decides which file groups are picked up for " | |||
+ "compaction during each compaction run. By default. Hudi picks the log file " | |||
+ "with most accumulated unmerged data"); | |||
+ "with most accumulated unmerged data. Support composite strategy by providing, format: strategy_class_name1,strategy_class_name2,..."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strategy can be composed with multiple strategies by concatenating the class names with ','.
public Builder withCompactionStrategy(CompactionStrategy... compactionStrategies) { | ||
StringBuilder compactionStrategyBuilder = new StringBuilder(); | ||
for (CompactionStrategy compactionStrategy : compactionStrategies) { | ||
compactionStrategyBuilder.append(compactionStrategy.getClass().getName()).append(","); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we trim out the tailing ,
?
|
||
/** | ||
* CompositeCompactionStrategy chains multiple compaction strategies together. | ||
* The order of the strategies in the chain is important as the output of one strategy is passed as input to the next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we address that the compisition predicate is and
instead of or
?
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
low
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist