[HUDI-7848] Fail comparisons between different typed ordering values #11961
+84
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linliu-code
force-pushed
the
HUDI-7848_verify_delete_record_ordering_value
branch
from
04be023
to
48d3582
Compare
linliu-code
changed the title
yihua
requested changes
Sep 19, 2024
Comment on lines
+216
to
+222
| } catch (ClassCastException e) { | ||
| throw new HoodieException(String.format( | ||
| "Cannot compare values: %s(%s), %s(%s)", | ||
| incomingOrderingValue, | ||
| incomingOrderingValue.getClass(), | ||
| existingOrderingValue, | ||
| existingOrderingValue.getClass())); |
There was a problem hiding this comment.
In MergeIntoHoodieTableCommand you need to validate the input schema first. If the schema is incompatible, the error should be thrown there. Deferring error here does not help user as this is not the root cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Remove ad hoc support for comparison between different types.
Risk level (write none, low medium or high below)
No.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist