[HUDI-8183] throw exception if key does not exist in record #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
reviewed
Sep 19, 2024
| String recordKeyValue = HoodieAvroUtils.getNestedFieldValAsString(record, recordKeyField, true, consistentLogicalTimestampEnabled); | ||
| String recordKeyValue; | ||
| try { | ||
| recordKeyValue = HoodieAvroUtils.getNestedFieldValAsString(record, recordKeyField, false, consistentLogicalTimestampEnabled); |
There was a problem hiding this comment.
Could you add a test case where the nested field does not exist and assert that the exception is thrown?
There was a problem hiding this comment.
Also create a follow-up JIRA to revisit all places this method can return null for non-existent field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
If the recordkey field doesn't exist at all, throw an exception
Impact
Currently happens silently so user won't know until they query the record
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist