Skip to content

Commit

Permalink
Address review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
yihua committed Mar 4, 2024
1 parent ca10086 commit fb664ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ _If medium or high, explain what verification was done to mitigate the risks._

### Documentation Update

_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "N/A"._
_Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._

- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
Expand Down
4 changes: 2 additions & 2 deletions scripts/pr_compliance.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def make_default_validator(body, debug=False):
"### Documentation Update",
{"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
"",
"- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",
"- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"none\"._",
"- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the",
" ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make",
" changes to the website._"})
Expand Down Expand Up @@ -479,7 +479,7 @@ def test_body():
"",
"_Describe any necessary documentation update if there is any new feature, config, or user-facing change_",
"",
"- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"N/A\"._",
"- _The config description must be updated if new configs are added or the default value of the configs are changed. If not, put \"none\"._",
"- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the",
" ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make",
" changes to the website._",
Expand Down

0 comments on commit fb664ad

Please sign in to comment.