Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1196: Fix compile issues with older VNC client versions where screen isn't defined. #549

Conversation

corentin-soriano
Copy link
Contributor

Fix for compilation error related to #544:

In file included from display.h:25,
                 from display.c:23:
display.c: In functionguac_vnc_send_desktop_size’:
display.c:206:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen206 |             rfbClientSwap16IfLE(client->screen.width),
      |                                       ^~
display.c:206:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen206 |             rfbClientSwap16IfLE(client->screen.width),
      |                                       ^~
display.c:206:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen206 |             rfbClientSwap16IfLE(client->screen.width),
      |                                       ^~
display.c:207:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen207 |             rfbClientSwap16IfLE(client->screen.height),
      |                                       ^~
display.c:207:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen207 |             rfbClientSwap16IfLE(client->screen.height),
      |                                       ^~
display.c:207:39: error: ‘rfbClient’ {akastruct _rfbClient’} has no member namedscreen207 |             rfbClientSwap16IfLE(client->screen.height),
      |                                       ^~
make[2]: *** [Makefile:618: libguac_client_vnc_la-display.lo] Error 1

@corentin-soriano corentin-soriano changed the base branch from main to staging/1.6.0 September 11, 2024 08:35
@corentin-soriano corentin-soriano force-pushed the GUACAMOLE-1196_fix_vnc_compilation_issue branch from efbea20 to dc028cd Compare September 11, 2024 08:36
@necouchman necouchman merged commit bd830f6 into apache:staging/1.6.0 Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants