GUACAMOLE-1026: Use LoadChannels callback method to load plugins with FreeRDP3. #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleitner
force-pushed
the
GUACAMOLE-1026-load-channels
branch
from
d4d891e
to
c19e6a9
Compare
aleitner
force-pushed
the
GUACAMOLE-1026-load-channels
branch
2 times, most recently
from
33b53f2
to
ff7ca6d
Compare
jmuehlner
reviewed
Sep 6, 2024
src/protocols/rdp/rdp.c
Outdated
| * @return | ||
| * Always TRUE. | ||
| */ | ||
| BOOL rdp_freerdp_load_channels(freerdp* instance) { |
There was a problem hiding this comment.
These (rdp_freerdp_load_channels and rdp_freerdp_pre_connect) should be declared as static if they're only used within this file.
jmuehlner
reviewed
Sep 6, 2024
aleitner
force-pushed
the
GUACAMOLE-1026-load-channels
branch
from
ff7ca6d
to
4e04989
Compare
jmuehlner
approved these changes
Sep 6, 2024
aleitner
force-pushed
the
GUACAMOLE-1026-load-channels
branch
4 times, most recently
from
4d5373c
to
2e7858e
Compare
jmuehlner
reviewed
Sep 6, 2024
src/protocols/rdp/rdp.c
Outdated
| * otherwise it can becalled directly from our pre_connect callback. It | ||
| * configures various features such as display resizing, multi-touch support, | ||
| * audio input, clipboard synchronization, device redirection, and graphics | ||
| * pipeline, by loading their correspondingplugins if they are enabled in the |
There was a problem hiding this comment.
Missing space: "correspondingplugins"
aleitner
force-pushed
the
GUACAMOLE-1026-load-channels
branch
from
2e7858e
to
dfc7d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins were not working properly when building Guacamole with FreeRDP3 due to a change in how they are loaded. This PR implements the LoadChannels callback function for loading plugins.
https://github.com/FreeRDP/FreeRDP/wiki/FreeRDP3-migration-notes