Bloom filter #438
Merged
Bloom filter #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, to ultimately simplify memory handling with wrapped filters
Pull Request Test Coverage Report for Build 10429686471Details
💛 - Coveralls |
|
I think I have addressed all the comments now |
filters/include/bloom_filter.hpp
Outdated
|
|
||
| // forward declarations | ||
| template<typename A> class bloom_filter_alloc; | ||
| template<typename A> class bloom_filter_builder_alloc; |
There was a problem hiding this comment.
do we still need this one?
There was a problem hiding this comment.
We do not. Removed, and will wait for tests to pass before merging,
AlexanderSaydakov
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a complete filter, including compatibility tests iwht java (that are not yet implemented in java!).
I'm look for feedback on how I handled wrapping. It feels a little too parallel to java in some ways, with
wrap()vswritable_wrap(), which I'm not sure is a good idea. The other issue is taht the former returns a const sketch, but counting the number of bits set may require modifying the filter. It should compute the number if it's in read-only mode so I could potentially add a const version of that method -- or just make it not update the internal state.Anyway, I'm fairly sure there are missed const values and other changes needed. But feel free to start with big picture design first and then move to details once we're happy with the overall structure.