added get_serialized_size_bytes() #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8399001848Details
💛 - Coveralls |
jmalkin
approved these changes
Mar 14, 2024
jmalkin
approved these changes
Mar 23, 2024
tdigest/include/tdigest_impl.hpp
Outdated
| void tdigest<T, A>::serialize(std::ostream& os) const { | ||
| const_cast<tdigest*>(this)->merge_buffered(); // side effect | ||
| void tdigest<T, A>::serialize(std::ostream& os, bool with_buffer) const { | ||
| if (!with_buffer) const_cast<tdigest*>(this)->compress(); // side effect | ||
| write(os, is_empty() || is_single_value() ? PREAMBLE_LONGS_EMPTY_OR_SINGLE : PREAMBLE_LONGS_MULTIPLE); |
There was a problem hiding this comment.
can call the newly added get_preamble_longs() here
| if (!with_buffer) const_cast<tdigest*>(this)->compress(); // side effect | ||
| vector_bytes bytes(get_serialized_size_bytes(with_buffer), 0, buffer_.get_allocator()); | ||
| uint8_t* ptr = bytes.data() + header_size_bytes; | ||
| *ptr++ = get_preamble_longs(); |
There was a problem hiding this comment.
One of the more aggressive warning flags complains about *ptr++ as possibly incrementing a null ptr
There was a problem hiding this comment.
I don't see how this would happen.
I thought about encapsulating this keeping track of the offset. or, perhaps, using something like std::strstream
| for (size_t i = 0; i < n; ++i) td.update(i); | ||
| // std::cout << td.to_string(true); |
There was a problem hiding this comment.
not a blocker but some extra comments left in it seems
There was a problem hiding this comment.
these are tests, and I uncomment this sometimes to check. not a big deal. we can kill this later
jmalkin
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.