register cpc teardown functions for std::atexit #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7282853175
💛 - Coveralls |
cleaner solution with no extra bool and check
Rearrange for better logical grouping
be explicit that we're ignoring the result of `atexit()` -- if it fails we'll just "leak" a bit of memory at shutdown, which we've been doing anyway so far.
use the right variable name
check if we can remove the extra template from the friend declaration of get_compressor()
Fix simplified friend declaration
AlexanderSaydakov
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::atexit()is apparently considered a legacy C thing since C++ should ideally be able to use static objects. Regardless, this worked to clean up: When I tested in valgrind we finally had a clean report for CPC for the first time ever.