Skip to content

Commit

Permalink
AOD sketch compatibility test
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexanderSaydakov committed Aug 1, 2023
1 parent be590ca commit ab602e9
Show file tree
Hide file tree
Showing 2 changed files with 82 additions and 0 deletions.
7 changes: 7 additions & 0 deletions tuple/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,10 @@ target_sources(tuple_test
array_of_doubles_sketch_test.cpp
engagement_test.cpp
)

if (SERDE_COMPAT)
target_sources(tuple_test
PRIVATE
aod_sketch_deserialize_from_java_test.cpp
)
endif()
75 changes: 75 additions & 0 deletions tuple/test/aod_sketch_deserialize_from_java_test.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

#include <catch2/catch.hpp>
#include <fstream>
#include <array_of_doubles_sketch.hpp>

namespace datasketches {

// assume the binary sketches for this test have been generated by datasketches-java code
// in the subdirectory called "java" in the root directory of this project
static std::string testBinaryInputPath = std::string(TEST_BINARY_INPUT_PATH) + "../../java/";

TEST_CASE("aod sketch one value", "[serde_compat]") {
unsigned n_arr[] = {0, 1, 10, 100, 1000, 10000, 100000, 1000000};
for (unsigned n: n_arr) {
std::ifstream is;
is.exceptions(std::ios::failbit | std::ios::badbit);
is.open(testBinaryInputPath + "aod_1_n" + std::to_string(n) + ".sk", std::ios::binary);
auto sketch = compact_array_of_doubles_sketch::deserialize(is);
REQUIRE(sketch.is_empty() == (n == 0));
REQUIRE(sketch.is_estimation_mode() == (n > 1000));
REQUIRE(sketch.get_estimate() == Approx(n).margin(n * 0.03));
REQUIRE(sketch.get_num_values() == 1);
for (const auto& entry: sketch) {
REQUIRE(entry.first < sketch.get_theta64());
}
}
}

TEST_CASE("aod sketch three values", "[serde_compat]") {
unsigned n_arr[] = {0, 1, 10, 100, 1000, 10000, 100000, 1000000};
for (unsigned n: n_arr) {
std::ifstream is;
is.exceptions(std::ios::failbit | std::ios::badbit);
is.open(testBinaryInputPath + "aod_3_n" + std::to_string(n) + ".sk", std::ios::binary);
auto sketch = compact_array_of_doubles_sketch::deserialize(is);
REQUIRE(sketch.is_empty() == (n == 0));
REQUIRE(sketch.is_estimation_mode() == (n > 1000));
REQUIRE(sketch.get_estimate() == Approx(n).margin(n * 0.03));
REQUIRE(sketch.get_num_values() == 3);
for (const auto& entry: sketch) {
REQUIRE(entry.first < sketch.get_theta64());
REQUIRE(entry.second[0] == entry.second[1]);
REQUIRE(entry.second[0] == entry.second[2]);
}
}
}

TEST_CASE("aod sketch non-empty no entries", "[serde_compat]") {
std::ifstream is;
is.exceptions(std::ios::failbit | std::ios::badbit);
is.open(testBinaryInputPath + "aod_1_non_empty_no_entries.sk", std::ios::binary);
auto sketch = compact_array_of_doubles_sketch::deserialize(is);
REQUIRE_FALSE(sketch.is_empty());
REQUIRE(sketch.get_num_retained() == 0);
}

} /* namespace datasketches */

0 comments on commit ab602e9

Please sign in to comment.