Minor: Consolidate UDF tests #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 29, 2023
| let actual = execute(&ctx, sql).await; | ||
| let expected = vec![vec!["0.6584408483418833"]]; | ||
| assert_float_eq(&expected, &actual); | ||
| let actual = plan_and_collect(&ctx, sql).await.unwrap(); |
There was a problem hiding this comment.
this was using a (very) old style to execute
| @@ -2330,87 +2330,6 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
moved to user defined tests
| @@ -886,18 +886,6 @@ async fn csv_query_nullif_divide_by_0() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
this was randomly in the file for testing exprs when it is actually an (user defined) aggregate query 😕
| @@ -101,54 +96,6 @@ pub mod select; | |||
| mod sql_api; | |||
| pub mod subqueries; | |||
| pub mod timestamp; | |||
| pub mod udf; | |||
|
|
|||
| fn assert_float_eq<T>(expected: &[Vec<T>], received: &[Vec<String>]) | |||
yjshen
approved these changes
Oct 3, 2023
|
Thanks @yjshen ! |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* Minor: Consolidate user defined functions * cleanup * move more tests * more * cleanup use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When evaluating coverage of our user defined functions (UDFs) I found that some tests were in sql_integration, and some were in other places.
What changes are included in this PR?
Consolidate them all into the aptly named
user_defined_integrationso they are easier to find.Are these changes tested?
all tests
Are there any user-facing changes?