Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add more examples for CREATE EXTERNAL TABLE doc #7594

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

comphead
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

Adding more example for CREATE EXTERNAL TABLE doc. Specifically how to register datasource on folder level, or with wildcards

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@comphead comphead changed the title Minor: add more example for CREATE EXTERNAL TABLE doc Minor: add more examples for CREATE EXTERNAL TABLE doc Sep 18, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comphead -- this looks great

1 row in set. Query took 0.007 seconds.
```
You can also query directories of files with compatible schemas:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

```shell
$ datafusion-cli
DataFusion CLI v16.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter, but it might be nice to have the versions be consistent

Suggested change
DataFusion CLI v16.0.0
DataFusion CLI v17.0.0

Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit bb6c57f into apache:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants