PR feedback

apache · Sep 13, 2023 · 7ae54c8 · 7ae54c8
1 parent 797ee30
commit 7ae54c8
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs b/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs
@@ -335,7 +335,6 @@ impl<ID: KeyType> HashTableItem<ID> {
     }
 }
 
-#[allow(dead_code)]
 #[cfg(test)]
 fn map_print<ID: KeyType>(map: &RawTable<HashTableItem<ID>>) {
     use itertools::Itertools;

diff --git a/datafusion/core/src/physical_plan/aggregates/topk/heap.rs b/datafusion/core/src/physical_plan/aggregates/topk/heap.rs
@@ -179,12 +179,6 @@ impl<VAL: ValueType> TopKHeap<VAL> {
         self.heap[0].as_ref().map(|hi| hi.map_idx).unwrap_or(0)
     }
 
-    #[allow(dead_code)]
-    pub fn len(&self) -> usize {
-        self.len
-    }
-
-    #[allow(dead_code)]
     pub fn is_full(&self) -> bool {
         self.len >= self.capacity
     }
@@ -334,7 +328,6 @@ impl<VAL: ValueType> TopKHeap<VAL> {
         valid
     }
 
-    #[allow(dead_code)]
     #[cfg(test)]
     pub fn tree_print(&self) -> String {
         let mut builder = ptree::TreeBuilder::new("BinaryHeap".to_string());