[CALCITE-6566] JDBC adapter should generate PI function with parenthe… #3956
+75
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses When unparse PI function without parentheses
caicancai
approved these changes
Sep 11, 2024
caicancai
reviewed
Sep 11, 2024
| @@ -1815,7 +1815,7 @@ public class SqlStdOperatorTable extends ReflectiveSqlOperatorTable { | |||
|
|
|||
| /** The {@code PI} function. */ | |||
| public static final SqlFunction PI = | |||
| SqlBasicFunction.create("PI", ReturnTypes.DOUBLE, OperandTypes.NILADIC, | |||
| SqlBasicFunction.create(SqlKind.PI, ReturnTypes.DOUBLE, OperandTypes.NILADIC, | |||
There was a problem hiding this comment.
Does this have to be changed to SqlKind.PI?
The others look good
|
Based on the discussion in jira, is there a more general way to implement this rather than being specific to |
@YiwenWu @caicancai Thanks for the review. We can discuss this in Jira. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ses When unparse PI function without parentheses