[CALCITE-4924] REGR_SXX and similar aggregate functions return the wr… #3928
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,12 +16,25 @@ | |
| */ | ||
| package org.apache.calcite.rel.type; | ||
|
|
||
| import org.apache.calcite.runtime.CalciteException; | ||
| import org.apache.calcite.runtime.Resources; | ||
| import org.apache.calcite.sql.SqlKind; | ||
| import org.apache.calcite.sql.SqlOperator; | ||
| import org.apache.calcite.sql.SqlOperatorBinding; | ||
| import org.apache.calcite.sql.SqlUtil; | ||
| import org.apache.calcite.sql.fun.SqlStdOperatorTable; | ||
| import org.apache.calcite.sql.parser.SqlParserPos; | ||
| import org.apache.calcite.sql.type.BasicSqlType; | ||
| import org.apache.calcite.sql.type.SqlTypeFamily; | ||
| import org.apache.calcite.sql.type.SqlTypeName; | ||
| import org.apache.calcite.sql.validate.SqlValidatorException; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
|
|
||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** Default implementation of | ||
| * {@link org.apache.calcite.rel.type.RelDataTypeSystem}, | ||
| * providing parameters from the SQL standard. | ||
|
|
@@ -255,8 +268,72 @@ | |
| return argumentType; | ||
| } | ||
|
|
||
| @Override public RelDataType deriveCovarType(RelDataTypeFactory typeFactory, SqlKind sqlKind, | ||
| RelDataType arg0Type, RelDataType arg1Type) { | ||
| switch (sqlKind) { | ||
| case REGR_SXX: | ||
| // REGR_SXX(x, y) → REGR_COUNT(x, y) * VAR_POP(y) | ||
|
|
||
| // REGR_COUNT(x, y) | ||
| RelDataType regrCountTypeSXX = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.REGR_COUNT, arg0Type, arg1Type); | ||
| // VAR_POP(y) | ||
| RelDataType varPopTypeY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.VAR_POP, arg1Type); | ||
| // REGR_COUNT(x, y) * VAR_POP(y) | ||
| return getOperatorRelDataType( | ||
| typeFactory, SqlStdOperatorTable.MULTIPLY, regrCountTypeSXX, varPopTypeY); | ||
|
|
||
| case REGR_SYY: | ||
| // REGR_SYY(x, y) → REGR_COUNT(x, y) * VAR_POP(x) | ||
|
|
||
| // REGR_COUNT(x, y) | ||
| RelDataType regrCountTypeSYY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.REGR_COUNT, arg0Type, arg1Type); | ||
| // VAR_POP(x) | ||
| RelDataType varPopTypeX = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.VAR_POP, arg0Type); | ||
| // REGR_COUNT(x, y) * VAR_POP(y) | ||
| return getOperatorRelDataType( | ||
| typeFactory, SqlStdOperatorTable.MULTIPLY, regrCountTypeSYY, varPopTypeX); | ||
|
|
||
| case COVAR_POP: | ||
| case COVAR_SAMP: | ||
| // COVAR_POP(x, y) → (SUM(x * y) - SUM(x) * SUM(y) / REGR_COUNT(x, y)) / REGR_COUNT(x, y) | ||
| // COVAR_SAMP(x, y) → (SUM(x * y) - SUM(x) * SUM(y) / REGR_COUNT(x, y)) / | ||
| // CASE REGR_COUNT(x, y) WHEN 1 THEN NULL ELSE REGR_COUNT(x, y) - 1 END | ||
|
|
||
| // (x * y) | ||
| RelDataType multiplyXY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.MULTIPLY, arg0Type, arg1Type); | ||
| // SUM(x * y) | ||
| RelDataType sumMultiplyXY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.SUM, multiplyXY); | ||
| // SUM(x) | ||
| RelDataType sumX = getOperatorRelDataType(typeFactory, SqlStdOperatorTable.SUM, arg0Type); | ||
| // SUM(y) | ||
| RelDataType sumY = getOperatorRelDataType(typeFactory, SqlStdOperatorTable.SUM, arg1Type); | ||
| // SUM(x) * SUM(y) | ||
| RelDataType multiplySumXSumY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.MULTIPLY, sumX, sumY); | ||
| // REGR_COUNT(x, y) | ||
| RelDataType regrCountXY = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.REGR_COUNT, arg0Type, arg1Type); | ||
| // SUM(x) * SUM(y) / REGR_COUNT(x, y) | ||
| RelDataType divide = | ||
| getOperatorRelDataType(typeFactory, | ||
| SqlStdOperatorTable.DIVIDE, multiplySumXSumY, regrCountXY); | ||
| // SUM(x * y) - SUM(x) * SUM(y) / REGR_COUNT(x, y) | ||
| RelDataType minus = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.MINUS, sumMultiplyXY, divide); | ||
| // (sum(x * y) - sum(x) * sum(y) / regr_count(x, y)) / regr_count(x, y) | ||
| RelDataType relDataType = | ||
| getOperatorRelDataType(typeFactory, SqlStdOperatorTable.DIVIDE, minus, regrCountXY); | ||
| if (sqlKind == SqlKind.COVAR_POP) { | ||
| return relDataType; | ||
| } | ||
| return typeFactory.createTypeWithNullability(relDataType, true); | ||
| } | ||
| return arg0Type; | ||
| } | ||
|
|
||
|
|
@@ -278,4 +355,37 @@ | |
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Implementation of the {@link SqlOperatorBinding} interface. | ||
| */ | ||
| public static class TypeCallBinding extends SqlOperatorBinding { | ||
| private final List<RelDataType> operands; | ||
|
|
||
| public TypeCallBinding(RelDataTypeFactory typeFactory, | ||
| SqlOperator sqlOperator, List<RelDataType> operands) { | ||
| super(typeFactory, sqlOperator); | ||
| this.operands = operands; | ||
| } | ||
|
|
||
| @Override public int getOperandCount() { | ||
| return operands.size(); | ||
| } | ||
|
|
||
| @Override public RelDataType getOperandType(int ordinal) { | ||
| return operands.get(ordinal); | ||
| } | ||
|
|
||
| @Override public CalciteException newError( | ||
| Resources.ExInst<SqlValidatorException> e) { | ||
| return SqlUtil.newContextException(SqlParserPos.ZERO, e); | ||
| } | ||
| } | ||
|
|
||
| private RelDataType getOperatorRelDataType(RelDataTypeFactory typeFactory, | ||
| SqlOperator sqlOperator, RelDataType... argumentTypes) { | ||
| ImmutableList<RelDataType> operatorTypeList = ImmutableList.copyOf(argumentTypes); | ||
| TypeCallBinding operatorBinding = | ||
| new TypeCallBinding(typeFactory, sqlOperator, operatorTypeList); | ||
| return sqlOperator.getReturnTypeInference().inferReturnType(operatorBinding); | ||
|
Check failure on line 389 in core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystemImpl.java
|
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a reasonable implementation, but from the test cases, it seems feasible.