Fixed JSON_OBJECT issue #3891
Open
Fixed JSON_OBJECT issue #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to create a jira case |
|
Requested account. Account will be under ***@***.*** ***@***.***>”.
… On Jul 29, 2024, at 12:49 PM, Cancai Cai ***@***.***> wrote:
You need to create a jira case
—
Reply to this email directly, view it on GitHub <#3891 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6XQV2343WGPJXHOXGMQ5M3ZOZXCDAVCNFSM6AAAAABLUTBLHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGQZDGOJTG4>.
You are receiving this because you authored the thread.
|
|
CALCITE-6505 has been created. |
mihaibudiu
requested changes
Jul 29, 2024
| String keyName = call.operand(i).toSqlString(this).toString(); | ||
| String value = call.operand(i + 1).toSqlString(this).toString(); | ||
| keyName = keyName.substring(1, keyName.length() - 1); | ||
| String jsonFragment = String.format("'\"%s\": ' || COALESCE(CASE WHEN %s::varchar ~'^-?\\\\d*(\\\\.\\\\d+)?$' THEN %s::varchar ELSE quote_ident(%s) END, 'null')", keyName, value, value, value); |
There was a problem hiding this comment.
this deserves an explanation as a comment
| import org.apache.calcite.sql.SqlNode; | ||
| import org.apache.calcite.sql.SqlUserDefinedTypeNameSpec; | ||
| import org.apache.calcite.sql.SqlWriter; | ||
| import org.apache.calcite.sql.*; |
There was a problem hiding this comment.
Calcite does not like * imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redshift has no JSON_OBJECT function, this rewrites JSON_OBJECT using ANSI SQL.