Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service #1200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BIGTOP-4028 : Excluding log dependencies corresponding to hbase in the hive service #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions bigtop-packages/src/common/hive/patch16-HIVE-SHELL.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/bin/hive b/bin/hive
index 1ade51e..f645ef1 100755
--- a/bin/hive
+++ b/bin/hive
@@ -293,7 +293,7 @@ if [ "$SKIP_HBASECP" = false ]; then
# exclude ZK, PB, and Guava (See HIVE-2055)
# depends on HBASE-8438 (hbase-0.94.14+, hbase-0.96.1+) for `hbase mapredcp` command
for x in $($HBASE_BIN mapredcp 2>&2 | tr ':' '\n') ; do
- if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* ]] ; then
+ if [[ $x == *zookeeper* || $x == *protobuf-java* || $x == *guava* || $x == *log* || $x == *slf4j* ]] ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*log* looks prone to future bug by matching unintentional files. What is the target jar here?
Same to *slf4j*. Are you really sure that all jars matching the pattern should be excluded?

continue
fi
# TODO: should these should be added to AUX_PARAM as well?