Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke teardown when DoFn throws in portable runners #32522

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 20, 2024

Fix (partly) #31381

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 20, 2024

java.lang.RuntimeException: Dataflow job 2024-09-20_12_32_18-8696550461908579531 terminated in state RUNNING but did not return a failure reason.
	at org.apache.beam.runners.dataflow.TestDataflowRunner.run(TestDataflowRunner.java:149)

however the job does succeeded. The worker log shows

2024-09-20 15:34:47.080 EDT
Entering instruction processing loop
2024-09-20 15:35:02.066 EDT
Memory is used/total/max = 392/890/4951 MB, GC last/max = 3.47/3.47 % (configured threshold: 50.00%), #pushbacks=0, gc thrashing=false
2024-09-20 15:40:02.073 EDT
Memory is used/total/max = 392/890/4951 MB, GC last/max = 0.00/3.47 % (configured threshold: 50.00%), #pushbacks=0, gc thrashing=false
2024-09-20 15:45:02.078 EDT
Memory is used/total/max = 88/930/4951 MB, GC last/max = 1.06/3.47 % (configured threshold: 50.00%), #pushbacks=0, gc thrashing=false
2024-09-20 15:47:46.638 EDT
Filepattern gs://apache-beam-samples/shakespeare/sonnets.txt matched 1 files with total size 95662

took extended period of time to match the file source (actually start to process data). Intermittent UW issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant