Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Fix bug where WorkerHandlerManager.close_all re-initialized state with incorrect dict type #32517

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

hjtran
Copy link
Contributor

@hjtran hjtran commented Sep 20, 2024

WorkerHandlerManager stores cached handlers as self._cached_handlers = defaultdict(str). When you reset the manager with manager.close_all() it resets the cached to just a regular dict instead of a default dict, i.e. self._cached_handlers = {}.

If you try to create another worker handler after calling close_all(), you'll get a KeyError.

@hjtran hjtran changed the title Fix bug where WorkerHandlerManager.close_all re-initialized state with incorrect dict type [Python] Fix bug where WorkerHandlerManager.close_all re-initialized state with incorrect dict type Sep 20, 2024
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrmccluskey jrmccluskey merged commit f2d0558 into apache:master Sep 20, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants