[Dataflow Streaming] Use isolated windmill streams based on job settings #32503
Conversation
arunpandianp
force-pushed
the
separatestreams
branch
3 times, most recently
from
3085cf0
to
295f9d0
Compare
arunpandianp
force-pushed
the
separatestreams
branch
from
295f9d0
to
9cb292a
Compare
arunpandianp
changed the title
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
Run Java Precommit |
.../java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDispatcherClient.java
Show resolved
Hide resolved
| // IsolationChannel will create and manage separate RPC channels to the same | ||
| // serviceAddress via calling the channelFactory, else just directly return the | ||
| // RPC channel. | ||
| useIsolatedChannels |
There was a problem hiding this comment.
would it be simpler to just have IsolatedChannel accept a atomic boolean that it then examines on whether or not it should perform the isolation or not?
It seems like we wouldn't have to have as much of the plumbing or the factoryfactory if we just always created an IsolatedChannel and just had a way to disable it's effect.
There was a problem hiding this comment.
The channels are cached by ChannelCache, so we have to somehow invalidate the caches when the setting changes. Current approach creates a second new ChannelCache and let the old one expire. Recreating the cache seems simpler than having to invalidate channels, track usage and expire them individually.
...ava/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillServerTest.java
Outdated
Show resolved
Hide resolved
The change is behind an experiment
streaming_engine_use_job_settings_for_isolated_channels. The experiment will be removed once backend changes are rollback safe.