-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use separate heartbeat streams based on job settings
- Loading branch information
1 parent
aeead3f
commit 3fd80af
Showing
4 changed files
with
179 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
...che/beam/runners/dataflow/worker/windmill/work/refresh/StreamPoolHeartbeatSenderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.runners.dataflow.worker.windmill.work.refresh; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import java.util.Optional; | ||
| import org.apache.beam.runners.dataflow.worker.FakeWindmillServer; | ||
| import org.apache.beam.runners.dataflow.worker.streaming.config.FixedGlobalConfigHandle; | ||
| import org.apache.beam.runners.dataflow.worker.streaming.config.StreamingGlobalConfig; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.Windmill.HeartbeatRequest; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.Windmill.UserWorkerRunnerV1Settings; | ||
| import org.apache.beam.runners.dataflow.worker.windmill.client.WindmillStreamPool; | ||
| import org.joda.time.Duration; | ||
| import org.junit.Test; | ||
| import org.junit.rules.ErrorCollector; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class StreamPoolHeartbeatSenderTest { | ||
|
|
||
| @Test | ||
| public void sendsHeartbeatsOnStream() { | ||
| FakeWindmillServer server = new FakeWindmillServer(new ErrorCollector(), c -> Optional.empty()); | ||
| StreamPoolHeartbeatSender heartbeatSender = | ||
| new StreamPoolHeartbeatSender( | ||
| WindmillStreamPool.create(1, Duration.standardSeconds(10), server::getDataStream)); | ||
| Heartbeats.Builder heartbeatsBuilder = Heartbeats.builder(); | ||
| heartbeatsBuilder | ||
| .heartbeatRequestsBuilder() | ||
| .put("key", HeartbeatRequest.newBuilder().setWorkToken(123).build()); | ||
| heartbeatSender.sendHeartbeats(heartbeatsBuilder.build()); | ||
| assertEquals(1, server.getGetDataRequests().size()); | ||
| } | ||
|
|
||
| @Test | ||
| public void sendsHeartbeatsOnDedicatedStream() { | ||
| FakeWindmillServer dedicatedServer = | ||
| new FakeWindmillServer(new ErrorCollector(), c -> Optional.empty()); | ||
| FakeWindmillServer getDataServer = | ||
| new FakeWindmillServer(new ErrorCollector(), c -> Optional.empty()); | ||
|
|
||
| FixedGlobalConfigHandle configHandle = | ||
| new FixedGlobalConfigHandle( | ||
| StreamingGlobalConfig.builder() | ||
| .setUserWorkerJobSettings( | ||
| UserWorkerRunnerV1Settings.newBuilder() | ||
| .setUseSeparateWindmillHeartbeatStreams(true) | ||
| .build()) | ||
| .build()); | ||
| StreamPoolHeartbeatSender heartbeatSender = | ||
| new StreamPoolHeartbeatSender( | ||
| WindmillStreamPool.create( | ||
| 1, Duration.standardSeconds(10), dedicatedServer::getDataStream), | ||
| WindmillStreamPool.create( | ||
| 1, Duration.standardSeconds(10), getDataServer::getDataStream), | ||
| configHandle); | ||
| Heartbeats.Builder heartbeatsBuilder = Heartbeats.builder(); | ||
| heartbeatsBuilder | ||
| .heartbeatRequestsBuilder() | ||
| .put("key", HeartbeatRequest.newBuilder().setWorkToken(123).build()); | ||
| heartbeatSender.sendHeartbeats(heartbeatsBuilder.build()); | ||
| assertEquals(1, dedicatedServer.getGetDataRequests().size()); | ||
| assertEquals(0, getDataServer.getGetDataRequests().size()); | ||
| } | ||
|
|
||
| @Test | ||
| public void sendsHeartbeatsOnGetDataStream() { | ||
| FakeWindmillServer dedicatedServer = | ||
| new FakeWindmillServer(new ErrorCollector(), c -> Optional.empty()); | ||
| FakeWindmillServer getDataServer = | ||
| new FakeWindmillServer(new ErrorCollector(), c -> Optional.empty()); | ||
|
|
||
| FixedGlobalConfigHandle configHandle = | ||
| new FixedGlobalConfigHandle( | ||
| StreamingGlobalConfig.builder() | ||
| .setUserWorkerJobSettings( | ||
| UserWorkerRunnerV1Settings.newBuilder() | ||
| .setUseSeparateWindmillHeartbeatStreams(false) | ||
| .build()) | ||
| .build()); | ||
| StreamPoolHeartbeatSender heartbeatSender = | ||
| new StreamPoolHeartbeatSender( | ||
| WindmillStreamPool.create( | ||
| 1, Duration.standardSeconds(10), dedicatedServer::getDataStream), | ||
| WindmillStreamPool.create( | ||
| 1, Duration.standardSeconds(10), getDataServer::getDataStream), | ||
| configHandle); | ||
| Heartbeats.Builder heartbeatsBuilder = Heartbeats.builder(); | ||
| heartbeatsBuilder | ||
| .heartbeatRequestsBuilder() | ||
| .put("key", HeartbeatRequest.newBuilder().setWorkToken(123).build()); | ||
| heartbeatSender.sendHeartbeats(heartbeatsBuilder.build()); | ||
| assertEquals(0, dedicatedServer.getGetDataRequests().size()); | ||
| assertEquals(1, getDataServer.getGetDataRequests().size()); | ||
| } | ||
| } |