Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability for top languages to count more than 100 repos #3483

Closed
wants to merge 1 commit into from

Conversation

jsoftich
Copy link

Changed the graphql query and added code to paginate until all repos pulled down(>first 100). The tests were also updated.

Copy link

vercel bot commented Nov 15, 2023

@jsoftich is attempting to deploy a commit to the github readme stats Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the lang-card Issues related to the language card. label Nov 15, 2023
@rickstaa
Copy link
Collaborator

@jsoftich Thanks for your pull request. Increasing the language count to more than 100 is impossible due to GraphQL rate limits (See #1852). We, however already have a pull request open to enable users to use this feature in the upcoming GitHub action (see #2111).

@rickstaa rickstaa closed this Nov 20, 2023
@jsoftich
Copy link
Author

@jsoftich Thanks for your pull request. Increasing the language count to more than 100 is impossible due to GraphQL rate limits (See #1852). We, however already have a pull request open to enable users to use this feature in the upcoming GitHub action (see #2111).

@rickstaa It does pull more than 100 with the pagination code that I added. Please take a look at this debug screen-shot

image

Copy link
Collaborator

@qwerty541 qwerty541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoftich Thanks for your pull request. Increasing the language count to more than 100 is impossible due to GraphQL rate limits (See #1852). We, however already have a pull request open to enable users to use this feature in the upcoming GitHub action (see #2111).

@rickstaa It does pull more than 100 with the pagination code that I added. Please take a look at this debug screen-shot

image

Hey, @jsoftich! Thanks for your pull request! GitHub GraphQL API has a 5000 points per hour limitation, at the moment it is a bottleneck for this project. Enabling ability to fetch more that 100 repositories on public instance will cause more often downtimes due to hitting API points limits. @rickstaa means that we can release this feature only under environment variable to allow users enable it on own private insance or with upcoming GitHub action.

@rickstaa
Copy link
Collaborator

@jsoftich Thanks for your pull request. Increasing the language count to more than 100 is impossible due to GraphQL rate limits (See #1852). We, however already have a pull request open to enable users to use this feature in the upcoming GitHub action (see #2111).

@rickstaa It does pull more than 100 with the pagination code that I added. Please take a look at this debug screen-shot
image

Hey, @jsoftich! Thanks for your pull request! GitHub GraphQL API has a 5000 points per hour limitation, at the moment it is a bottleneck for this project. Enabling ability to fetch more that 100 repositories on public instance will cause more often downtimes due to hitting API points limits. @rickstaa means that we can release this feature only under environment variable to allow users enable it on own private insance or with upcoming GitHub action.

@jsoftich sorry for being unclear. @qwerty541 is correct. Although it is more than possible to implement this using GraphQL it is not possible to merge this into the main branch due to the GraphQL rate limits. We will merge #2111 which does the same as your pull request in the future under an environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-card Issues related to the language card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants