GoBgp client cli capability

[rajnkamr]

Add GoBGP client cli capability to Antrea Agent
gobgp image size is 15 MB

#6189

[luolanzone]

I am not sure I get the point of this PR, please add more details in the PR summary to clarify what you want to implement in this PR.

[rajnkamr]

I am not sure I get the point of this PR, please add more details in the PR summary to clarify what you want to implement in this PR.

Details available in #6189 ( #6541 )

[antoninbas]

Let's discuss in #6189 before committing to an approach for this

[antoninbas]

In the commit message, please indicate the increase in image size for antrea/antrea-agent-ubuntu:latest because of this change (uncompressed image size, which can be obtained with docker images).

[antoninbas]

LGTM
I would like @tnqn to take a look at it as well to make sure he is ok with the increase in image size, especially considering the ongoing work for #6646

[tnqn]

@antoninbas Thanks for checking my opinion.

@rajnkamr Can you update the description to point to the right issue #6541? #6189 barely provides any information.

However, #6541 doesn't have information about how the gobgp CLI can/will be used either, it says "advanced live debugging", but without a single example. Does antrea-agent even open a socket for gobgp CLI to connect? I don't find such socket. Have you validated any command can work?

Besides, is it right to open such socket to introduce another source of truth of bgp routes? Unlike the typical gobgpd and gobgp case that the latter is used to configure the former, we only leverage the gobgp library to implement bgp using the BGPPolicy as the source of truth. Maybe it could be helpful in read-only mode but I guess there is no permission control in such granularity once the socket is there. Who is supposed to use the CLI, users, developers, or both?

Lastly, I remember there was a topic to have other BGP implementations if required, I suppose gobgp CLI won't work for other implementations?

[tnqn]

Generally we should avoid adding things to image when there is no strong reason. Despite of the image size, every dependency comes with CVEs and maintenance efforts. If the reason is just maybe helpful for some scenarios (and in the particular case non use case has been shown), maybe let's at least defer to when users/developers have to install gobgp themselves to address their use cases?

Actually there are many useful networking tools I frequently use when debugging: netstat, tcpdump, etc., which are even more common and frequently used than gobgp. You can imagine the impact to image size if all of them are added. At least it's not a problem for me to install tools / use ephemeral containers when there is a need.