Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new signature template #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BerniWittmann
Copy link
Contributor

@BerniWittmann BerniWittmann commented Oct 4, 2019

Added a new email signature template, which puts a stronger focus on the
name.

Bildschirmfoto 2019-10-04 um 22 36 26

I also did the tests with my email client, and the gmail web client.

Thank you for your contribution to the mysigmail repo.
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • Your commits follow the сonvention

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor

If is a feature which add new template

  • Testing copying: Copy as Select and Copy as HTML
  • Testing in Gmail (web client) via Copy as Select
  • Testing in other email client via Copy as HTML
  • Result is same as in preview in app

Importantly

To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on PR

Added a new email signature template, which puts a stronger focus on the 
name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant