Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove L2 Execution Payload #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Remove L2 Execution Payload #542

wants to merge 1 commit into from

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 20, 2024

Description

Removes the L2ExecutionPayload type, changing the L2ChainProvider trait to return OpBlock by number instead of payload by number. This type was effectively just used as an intermediate type to convert between raw block from debug_getRawBlock and transactions, l2 block ref, and system config used to validate span batches.

Copy link
Collaborator Author

refcell commented Sep 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat: remove l2 execution payload feat: Remove L2 Execution Payload Sep 20, 2024
@refcell refcell requested a review from clabby September 20, 2024 22:19
@refcell refcell added A-derive Area: Derivation pipeline A-primitives Area: `kona-primitives` crate K-feature Kind: feature labels Sep 20, 2024 — with Graphite App
Copy link

codecov bot commented Sep 20, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
13 2 11 0
View the top 2 failed tests by shortest run time
kona-derive batch::span_batch::batch::tests::test_check_batch_failed_to_fetch_payload
Stack Traces | 0.014s run time
thread 'batch::span_batch::batch::tests::test_check_batch_failed_to_fetch_payload' panicked at .../batch/span_batch/batch.rs:1371:9:
assertion failed: logs[0].contains("failed to fetch payload for block number 41: Payload not found")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
kona-derive batch::span_batch::batch::tests::test_check_batch_failed_to_extract_l2_block_info
Stack Traces | 0.024s run time
thread 'batch::span_batch::batch::tests::test_check_batch_failed_to_extract_l2_block_info' panicked at .../batch/span_batch/batch.rs:1437:9:
assertion failed: logs[0].contains(&str)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@refcell refcell marked this pull request as ready for review September 20, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: Derivation pipeline A-primitives Area: `kona-primitives` crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant