Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): Walkback Channel Timeout #456

Merged
merged 5 commits into from
Aug 27, 2024
Merged

fix(client): Walkback Channel Timeout #456

merged 5 commits into from
Aug 27, 2024
+19 −21

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 23, 2024 •
edited
Loading

Description

Walkback channel timeout in the client. Replaces #427

Metadata

Fixes #417

@refcell Graphite App
Copy link
Collaborator Author

refcell commented Aug 23, 2024 •
edited by clabby
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title fix(client): walkback channel timeout fix(client): Walkback Channel Timeout Aug 23, 2024
@refcell refcell requested a review from clabby August 23, 2024 20:54
@refcell refcell added the A-common Area: `kona-common` crate label Aug 23, 2024 — with Graphite App
@refcell refcell removed the A-common Area: `kona-common` crate label Aug 23, 2024
@refcell refcell added A-client Area: client binary K-fix Kind: fix labels Aug 23, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review August 23, 2024 20:54
@refcell refcell self-assigned this Aug 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (df189a2) to head (db3e07d).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the rf/fix/channel-timeout-walkback branch 2 times, most recently from 9f28b6d to e5a89ff Compare August 27, 2024 19:28
@clabby clabby force-pushed the rf/fix/channel-timeout-walkback branch from ee6fe9b to db3e07d Compare August 27, 2024 20:06
@clabby clabby mentioned this pull request Aug 27, 2024
Merged
@clabby clabby enabled auto-merge August 27, 2024 20:07
@clabby clabby added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 952390d Aug 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-client Area: client binary K-fix Kind: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(client): Respect channel timeout
3 participants
@refcell @codecov-commenter @clabby