Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Respect channel timeout #417

Closed
clabby opened this issue Aug 5, 2024 · 1 comment · Fixed by #456 · May be fixed by #427
Closed

fix(client): Respect channel timeout #417

clabby opened this issue Aug 5, 2024 · 1 comment · Fixed by #456 · May be fixed by #427
Labels
A-client Area: client binary K-bug Kind: bug

Comments

@clabby
Copy link
Collaborator

clabby commented Aug 5, 2024

Overview

Currently, we don't respect the channel timeout in kona-client. This change will be a painful one to make for performance, but we need to respect consensus rules rather than batcher policy.

In real-world application, the OP Stack batcher almost always opens and closes channels in a single transaction. However, this is strictly not guaranteed by the protocol.

To accommodate for this, we must start derivation at least RollupConfig::channel_timeout blocks before the L1 origin of the trusted safe head.

https://github.com/ethereum-optimism/kona/blob/e069eb4178af1a2a7ea1f772f3f35c240d178534/bin/client/src/l1/driver.rs#L203-L203

@clabby clabby added K-bug Kind: bug A-client Area: client binary labels Aug 5, 2024
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Aug 5, 2024
@clabby clabby assigned clabby and unassigned clabby Aug 5, 2024
@refcell refcell removed this from the Phase 3: Kona Client & Host milestone Aug 9, 2024
@refcell
Copy link
Collaborator

refcell commented Aug 11, 2024

Discussed offline: attempt to derive the channel in the happy path from the l1 origin. If it fails to derive the channel, walk back the channel timeout window of L1 blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client binary K-bug Kind: bug
Projects
None yet
2 participants