add_clickhouse_g4 #4234
Open
add_clickhouse_g4 #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I want to directly use the G4 file in the source code, I encounter the following problem. |
|
@teverett Please take a look, thank you very much |
KvanTTT
requested changes
Sep 19, 2024
| // $antlr-format alignTrailingComments true, allowShortBlocksOnASingleLine true, allowShortRulesOnASingleLine true, columnLimit 150 | ||
| // $antlr-format maxEmptyLinesToKeep 1, minEmptyLines 0, reflowComments false, singleLineOverrulesHangingColon true, useTab false | ||
|
|
||
| lexer grammar ClickHouseLexer; |
There was a problem hiding this comment.
Could you please use caseInsensitive option in lexer and replace fragments with string literals? See SQL grammars as an example.
There was a problem hiding this comment.
Thank you for your advice. But replacing all fragments will make a big change to the g4 file in clickhouse source code and makes little sense to the lexer result. Is it necessary to do this format change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the G4 file in the clickhouse source code, I made some modifications to adapt to the static SQL parsing of antlr4.