Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ibc transparent balance #117

Merged
merged 4 commits into from
Sep 19, 2024
Merged

feat: ibc transparent balance #117

merged 4 commits into from
Sep 19, 2024

Conversation

mateuszjasiuk
Copy link
Contributor

@mateuszjasiuk mateuszjasiuk commented Sep 11, 2024 •
edited
Loading

Balances will look like this:

   │  id │ owner                                         │ token                                         │ raw_amount
───┼─────┼───────────────────────────────────────────────┼───────────────────────────────────────────────┼────────────
 1 │ 182 │ tnam1qr8pgymj695tap0207jhr9462lq2esxnd5v4gld9 │ tnam1q87wtaqqtlwkw927gaff34hgda36huk0kgry692a │ 999200330
 2 │ 332 │ tnam1qr8pgymj695tap0207jhr9462lq2esxnd5v4gld9 │ transfer/channel-10/uatom                     │ 60
 3 │ 333 │ tnam1qr8pgymj695tap0207jhr9462lq2esxnd5v4gld9 │ transfer/channel-11/uatom                     │ 20

@mateuszjasiuk mateuszjasiuk force-pushed the feat/ibc-transparent-balance branch 2 times, most recently from c62fd4f to 3ecc7c5 Compare September 12, 2024 16:37
@mateuszjasiuk mateuszjasiuk changed the title WIP: feat: ibc transparent balance feat: ibc transparent balance Sep 13, 2024
Fraccaman
Fraccaman reviewed Sep 13, 2024
View reviewed changes
shared/src/checksums.rs Outdated
Comment on lines 33 to 34
TX_REVEAL_PK.to_string(),
TX_REVEAL_PK.to_string(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double reveal pk?

Copy link
Contributor Author

@mateuszjasiuk mateuszjasiuk Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah if you want to reveal it twice, np
edit: fixed

@Fraccaman
Copy link
Member

everything else lgtm

@mateuszjasiuk mateuszjasiuk added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 3d82460 Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fraccaman Fraccaman Fraccaman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszjasiuk @Fraccaman