Dedup the gradle bits of audio-echo. #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanAlbert
force-pushed
the
build-logic
branch
3 times, most recently
from
34756ea
to
983107c
Compare
jfgoog
approved these changes
May 9, 2024
Apparently gradle's new version catalogs only work in certain contexts, so we still need a convention plugin to be able to centralize decisions like compileSdk and targetSdk. I'm starting with those for now to prove it out, then will expand it to cover other interesting things like NDK version.
Do with with new convention plugin. I'll keep factoring things out this way until I'm happy with this sample and then move on to the others.
I don't know what that comment is trying to say, and the NDK doesn't support anything older than 21 now anyway. I've also dropped the minSdk back to 21. I'm not sure why 23 was chosen. None of the APIs used require anything newer, and the sample just works fine on my volantis running L.
minifyEnabled already defaults to false. aiui that's in all the templates (and it still is in the template for a newly created project) as a hint for something developers may want to turn on later. It doesn't add anything to the sample if we're not actually going to enable it, and I'm not going to go figure out what proguard changes need to happen to enable it right now. Maybe later. Since minification isn't used, the proguard config does nothing.
We don't have any JARs, so that's gone. appcompat is defined by the version catalog, so switch to that. The catalog does define 1.6.1 right now, so this is also an upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used audio-echo as the proof of concept. I'll follow up with the other samples after this merges, but this PR includes all the plumbing.
See build-logic/README.md for an explanation. I copied fairly shamelessly from the linked Now In Android sample :)
As with the others currently up, shouldn't merge before the sample indexing service is updated, since this is the PR that'll make the samples actually depend on the parent project.