Combine samples project #1021
Closed
Combine samples project #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been cargo culted forward in each sample for who knows how long. Most of these don't use kotlin or the library plugin. The clean task bit I think was a workaround for a very old AGP bug that was in the new app templates, but if I create a new project with AS now, it's no longer included.
Not actually a proper upgrade, but the other samples that use Kotlin are all on 1.7.21.
gradle.properties, afaict, can't be applied per module. Once these are all in one giant project we want to apply this property at a finer scope than globally, so move it to buildFeatures, which are preferred anyway.
This is step on of android#1010. It's not really finished until I've removed all the stuff left behind (which I'm leaving for another PR because it's just a big mess of deletes that'd make this PR harder to read). It's may be good to also remove the mostly unnecessary middle directories from most of these. Doing that will break a bunch of existing URLs, but if the goal is to be a project that's actually sensible to copy, we need to rearrange to do that. Maybe that's better left for a broader rearranging that's probably overdue anyway, or maybe we should just leave it as-is to keep the URLs alive.
This obviously isn't used, and it's failing when building the whole samples repo as a group for some reason I don't care to debug. Something something manifest for the test APK is wrong.
Only a few of these show anything interesting about ndk-build. Keep those and remove the rest. The few that remain will be merged with the CMake equivalents.
Fixes the lint task that's complaining that this app wouldn't be allowed in Play.
afaict this directory hasn't been named lib64 for quite some time, and it definitely isn't for the NDK this sample uses on macOS. `find prebuilts/clang/host -name lib64` only finds one version of Clang where this was named lib64 (there were likely others that have since been removed from the repos, but they'll be rather old). This wasn't caught by CI because the shell script that drives the build only builds the default build type. That will be fixed automatically as part of android#1010.
This was previously only scoped to ASan. Move it up to the module directory so it covers all variants.
|
Whoops, wrong branch. Uploaded too early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.