Fix sanitizer search paths. #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afaict this directory hasn't been named lib64 for quite some time, and it definitely isn't for the NDK this sample uses on macOS. `find prebuilts/clang/host -name lib64` only finds one version of Clang where this was named lib64 (there were likely others that have since been removed from the repos, but they'll be rather old). This wasn't caught by CI because the shell script that drives the build only builds the default build type. That will be fixed automatically as part of android#1010.
|
@fmayer I can't add you as a reviewer, presumably that also means your vote won't count? |
fmayer
approved these changes
May 7, 2024
jfgoog
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
afaict this directory hasn't been named lib64 for quite some time, and it definitely isn't for the NDK this sample uses on macOS.
find prebuilts/clang/host -name lib64only finds one version of Clang where this was named lib64 (there were likely others that have since been removed from the repos, but they'll be rather old).This wasn't caught by CI because the shell script that drives the build only builds the default build type. That will be fixed automatically as part of #1010.